Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[gradle] Add 4 boolean properties supported by codegenConfigurator #1881

Merged
merged 2 commits into from
Jan 11, 2019

Conversation

jimschubert
Copy link
Member

@jimschubert jimschubert commented Jan 11, 2019

PR checklist

  • Read the contribution guidelines.
  • Ran the shell script under ./bin/ to update Petstore sample so that CIs can verify the change. (For instance, only need to run ./bin/{LANG}-petstore.sh and ./bin/security/{LANG}-petstore.sh if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in .\bin\windows\.
  • Filed the PR against the correct branch: master, 3.4.x, 4.0.x. Default: master.
  • Copied the technical committee to review the pull request if your PR is targeting a particular programming language.

Description of the PR

Adds missing options supported by codegenConfigurator for consistency with maven plugin (see #1845)

Also includes documentation for a workaround found to address #1818.

After release 3.0.0, a guava dependency was updated and this exposed an
issue in Windows where Guava's CharMatcher.ASCII is called to validate a
path. The version of Guava referenced by OpenAPI Generator causes a
'NoSuchField' error because the referenced dependency names this static
field CharMatcher.Ascii.

This error is not surfaced on macOS, and appears to be Windows-specific.

This adds a potential workaround to the Gradle plugin's readme.

See #1818 for more details.
@jimschubert
Copy link
Member Author

@wing328 heads up that I've knocked out those properties in the gradle plugin that you added to the maven plugin.

@wing328 wing328 added this to the 4.0.0 milestone Jan 11, 2019
Copy link
Member

@wing328 wing328 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wing328 wing328 merged commit 4fa9266 into master Jan 11, 2019
jimschubert added a commit that referenced this pull request Jan 12, 2019
* master:
  Add links to Patreon account (#1887)
  Python AIOHTTP server generator (#1470)
  Fix a problem that points to a folder that doesn't exist (#1863)
  Python: Update api_doc_example for multiple auth (#1870)
  [gradle] Add 4 boolean properties supported by codegenConfigurator (#1881)
@wing328 wing328 deleted the gradle-plugin-additional-ops branch January 14, 2019 14:53
A-Joshi pushed a commit to ihsmarkitoss/openapi-generator that referenced this pull request Feb 27, 2019
…penAPITools#1881)

* [gradle] Add 4 boolean properties supported by codegenConfigurator

* [gradle] Add Windows workaround for Android Studio

After release 3.0.0, a guava dependency was updated and this exposed an
issue in Windows where Guava's CharMatcher.ASCII is called to validate a
path. The version of Guava referenced by OpenAPI Generator causes a
'NoSuchField' error because the referenced dependency names this static
field CharMatcher.Ascii.

This error is not surfaced on macOS, and appears to be Windows-specific.

This adds a potential workaround to the Gradle plugin's readme.

See OpenAPITools#1818 for more details.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants